Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RLlib] No Preprocessors; preparatory PR #1 #18367

Merged

Conversation

sven1977
Copy link
Contributor

@sven1977 sven1977 commented Sep 5, 2021

This PR was motivated in preparation for soon allowing individual observation components to be addressed by the trajectory view API, for example to enable frame-stacking for individual observation components within a complex observation space (Tuple|Dict). Also, soon soft-deprecating RLlib's Preprocessor API should increase transparency for the users and allow batched, model-based preprocessing of observations. Observations will arrive in the model exactly as they are returned by the env.

This PR is a preparatory PR that lays some groundwork in order to fully support this feature (in 1 follow up PR).

  • New config setting for preprocessor_pref: None; Set to None for disabling Preprocessors altogether (not even use NoPreprocessor class anymore).
  • ComplexInputModel (which already exists and handles complex, unflattened inputs) was enhanced to support Dict inputs as well (so far, only Tuple inputs).
  • Some docs strings and comments added.

Why are these changes needed?

Related issue number

Checks

  • I've run scripts/format.sh to lint the changes in this PR.
  • I've included any doc changes needed for https://docs.ray.io/en/master/.
  • I've made sure the tests are passing. Note that there might be a few flaky tests, see the recent failures at https://flakey-tests.ray.io/
  • Testing Strategy
    • Unit tests
    • Release tests
    • This PR is not tested :(

@sven1977 sven1977 added the tests-ok The tagger certifies test failures are unrelated and assumes personal liability. label Sep 5, 2021
@sven1977 sven1977 merged commit 8a06647 into ray-project:master Sep 9, 2021
@sven1977 sven1977 mentioned this pull request Sep 9, 2021
6 tasks
@sven1977 sven1977 deleted the poc_deprecate_preprocessors_part_1 branch June 2, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests-ok The tagger certifies test failures are unrelated and assumes personal liability.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants