[core][client] Remove protocol version, instead just compare Ray and Python versions. #42760
Conversation
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
|
Were you able to find out why this is there in the first place? Shouldn't this constant be the same on a given ray version anyway? |
|
Eric explained it was safe to remove it. Did not track to its genesis though. |
|
Okay, sounds good. If you want to track something to it's genesis, you can use
^I'm still wondering about this. I'm also not sure if this fixes anything with #42356, isn't this removing a layer of version checking? |
| + f" client is {version_str}," | ||
| + f" server is {conn_info['python_version']}" | ||
| ) | ||
| if ignore_version or "RAY_IGNORE_VERSION_MISMATCH" in os.environ: |
There was a problem hiding this comment.
Are we removing behavior for RAY_IGNORE_VERSION_MISMATCH intentionally?
There was a problem hiding this comment.
Added back. Thanks for spotting it!
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
…e-protocol-version Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
Signed-off-by: Ruiyang Wang <rywang014@gmail.com>
|
@ericl tests passed. please take a look! Thanks. |
|
@ericl friendly ping |
In a regular Ray worker init, (python version, ray version) is compared against the cluster. In Ray Client, however, a (python version, protocol_version) is compared. This makes it a looser requirement for the client connection than for the workers.
This commit removes that and unifies version check between both sides to (python version, ray version). This helps avoiding any confusion in version mismatch.
Fixes #42356