impl IntoParallelIterator for tuples => MultiZip #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implemented for tuples up to arity 12, much like the standard library's trait implementations. - For `(a, b, ...)`, it calls `into_par_iter()` on each member. - For `&(a, b, ...)`, it calls `par_iter()` on each member. - For `&mut (a, b, ...)`, it calls `par_iter_mut()` on each member. The resulting `MultiZip` iterator returns a tuple of the zipped items from each input iterator. Internally, it is implemented with macros that forward to a series of regular `zip`s, mapping to a flattened tuple.
cuviper
changed the title
|
My obvious hesitation is that this goes beyond the surface area of libstd. But I think it makes a lot of sense to have |
nikomatsakis
approved these changes
Dec 18, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 18, 2019
711: impl IntoParallelIterator for tuples => MultiZip r=nikomatsakis a=cuviper This is implemented for tuples up to arity 12, much like the standard library's trait implementations. - For `(a, b, ...)`, it calls `into_par_iter()` on each member. - For `&(a, b, ...)`, it calls `par_iter()` on each member. - For `&mut (a, b, ...)`, it calls `par_iter_mut()` on each member. The resulting `MultiZip` iterator returns a tuple of the zipped items from each input iterator. Internally, it is implemented with macros that forward to a series of regular `zip`s, mapping to a flattened tuple. Closes #567. Co-authored-by: Josh Stone <cuviper@gmail.com>
Build failed |
|
It seems windows-gnu is broken: rust-lang/rust#67408 |
bors bot
added a commit
that referenced
this pull request
Dec 18, 2019
714: Reduce Windows CI to just stable Rust r=cuviper a=cuviper CI for #711 ran into a broken beta windows-gnu toolchain, which is frustrating, but in general I already feel that it's overkill to test so much on Windows. The Linux builds on Travis CI already test a breadth of compiler versions, and it does so in parallel, whereas Appveyor runs serially. We can just test Windows stable to be sure the platform works at all, and leave it at that. Co-authored-by: Josh Stone <cuviper@gmail.com>
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Dec 18, 2019
711: impl IntoParallelIterator for tuples => MultiZip r=nikomatsakis a=cuviper This is implemented for tuples up to arity 12, much like the standard library's trait implementations. - For `(a, b, ...)`, it calls `into_par_iter()` on each member. - For `&(a, b, ...)`, it calls `par_iter()` on each member. - For `&mut (a, b, ...)`, it calls `par_iter_mut()` on each member. The resulting `MultiZip` iterator returns a tuple of the zipped items from each input iterator. Internally, it is implemented with macros that forward to a series of regular `zip`s, mapping to a flattened tuple. Closes #567. Co-authored-by: Josh Stone <cuviper@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented for tuples up to arity 12, much like the standard
library's trait implementations.
(a, b, ...), it callsinto_par_iter()on each member.&(a, b, ...), it callspar_iter()on each member.&mut (a, b, ...), it callspar_iter_mut()on each member.The resulting
MultiZipiterator returns a tuple of the zipped itemsfrom each input iterator. Internally, it is implemented with macros that
forward to a series of regular
zips, mapping to a flattened tuple.Closes #567.