Add library versioning to Make/CMake build systems #417
Conversation
|
I tested this on Linux and macOS. |
|
Hi @a3f! Thank you very much for the addition! Just added one comment review... |
src/meson.build
Outdated
| @@ -18,5 +18,5 @@ raylib = library('raylib', | |||
| source_c, | |||
| dependencies : [ glfw_dep, gl_dep, openal_dep, m_dep, x11_dep], | |||
| install : true, | |||
| version : '1.8.0') | |||
| version : '1.9.2') | |||
There was a problem hiding this comment.
this is the library version.
https://github.com/raysan5/raylib/blob/master/meson.build#L1 is the version of raylib.
There was a problem hiding this comment.
Should both be set to the same new value and if so what's the difference?
There was a problem hiding this comment.
I removed the changes to meson.build, so you can see what changes would be appropriate.
There was a problem hiding this comment.
It might be best to remove meson.build and src/meson.build completely, since with this PR it doesn't provide anything more than Make/CMake does provide.
There was a problem hiding this comment.
That would be a possibility as well. I pushed one more commit that does that.
See raysan5#401 for the discussion. Also bumps version number to 1.9.2 without the -dev, because neither ELF nor MachO like such a suffix. The -dev suffix will have to be restricted to the git tags.
Less maintenance overhead that way, given that make/CMake now also do library versioning.
See #401 for the discussion.
Also bumps version number to 1.9.2 without the -dev,
because neither ELF nor MachO like such a suffix for the compatibility version.
The -dev suffix will have to be restricted to the git tags.