Recovery/Replication changes for Writable Warm Index #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
…RemoteStoreFileTrackerAdapter, CompositeDirectoryFactory and update Composite Directory implementation Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
…ace to fetch an InputStream instead Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
…teIndexInput Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
…view fixes Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
…ment fixes Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
…til uploaded to Remote Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
Signed-off-by: Shreyansh Ray <rayshrey@amazon.com>
mch2
reviewed
May 29, 2024
| super.testDropPrimaryDuringReplication(); | ||
| } | ||
|
|
||
| public void testPressureServiceStats() throws Exception { |
There was a problem hiding this comment.
you don't need all these super calls, it will run all parent tests when you inherit it.
mch2
reviewed
May 29, 2024
|
|
||
| @OpenSearchIntegTestCase.ClusterScope(scope = OpenSearchIntegTestCase.Scope.TEST, numDataNodes = 0) | ||
| @ThreadLeakFilters(filters = CleanerDaemonThreadLeakFilter.class) | ||
| public class WarmIndexRemoteStoreSegmentReplicationIT extends SegmentReplicationIT { |
There was a problem hiding this comment.
would prefer we add parameterization to SegmentReplicationIT or the remote store version that randomly enables writeable warm here vs duplicating the suite.
rayshrey
force-pushed
the
composite-directory-poc
branch
from
78fee6e to
fd20fad
Compare
rayshrey
force-pushed
the
composite-directory-poc
branch
3 times, most recently
from
57eca38 to
901849b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.