fix: temporary fix for double cyclic (#725)

raystack · Jan 18, 2023 · 396493b · 396493b
1 parent 5f2c317
commit 396493b
Showing 1 changed file with 3 additions and 8 deletions.
diff --git a/core/job/service/job_service.go b/core/job/service/job_service.go
@@ -357,15 +357,10 @@ func (j JobService) Validate(ctx context.Context, jobTenant tenant.Tenant, jobSp
 	}
 
 	// check cyclic deps for every job
-	isAlreadyCyclic := map[string]bool{}
 	for _, jobEntity := range jobsWithUnresolvedUpstreams {
-		if jobNamesWithCyclic, err := j.validateCyclic(jobEntity.Job().Spec().Name(), jobMap, identifierToJobsMap); err != nil {
-			if _, ok := isAlreadyCyclic[jobEntity.Job().Spec().Name().String()]; !ok {
-				me.Append(err)
-			}
-			for _, jobName := range jobNamesWithCyclic {
-				isAlreadyCyclic[jobName] = true
-			}
+		if _, err := j.validateCyclic(jobEntity.Job().Spec().Name(), jobMap, identifierToJobsMap); err != nil {
+			me.Append(err)
+			break
 		}
 	}