Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize cli colors #361

Merged
merged 3 commits into from
Jun 7, 2022
Merged

Conversation

arinda-arif
Copy link
Contributor

@arinda-arif arinda-arif commented May 23, 2022

Color initialization is being done in the root command's PersistentPreRun function. However, this function is not being run as it is overridden by the child's PersistentPreRun.

The color init is not necessarily placed in the root's PersistentPreRun, thus moving it to the root command's constructor.

@arinda-arif arinda-arif linked an issue May 23, 2022 that may be closed by this pull request
@coveralls
Copy link

coveralls commented May 23, 2022

Pull Request Test Coverage Report for Build 2447308666

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 399 unchanged lines in 29 files lost coverage.
  • Overall coverage increased (+2.1%) to 77.104%

Files with Coverage Reduction New Missed Lines %
api/handler/v1beta1/namespace.go 1 94.44%
models/plugin.go 1 2.24%
extension/extension.go 2 60.0%
service/namespace_service.go 2 96.97%
service/project_service.go 2 93.33%
utils/file.go 2 35.0%
api/handler/v1beta1/backup.go 3 96.67%
job/deploy_manager.go 3 90.2%
api/handler/v1beta1/project.go 4 64.1%
ext/datastore/bigquery/dataset.go 4 95.29%
Totals Coverage Status
Change from base Build 2368745500: 2.1%
Covered Lines: 7119
Relevant Lines: 9233

💛 - Coveralls

@arinda-arif arinda-arif self-assigned this May 24, 2022
@arinda-arif arinda-arif changed the title fix: add root PersistentPreRun call to show colors on subcommand fix: initialize cli colors May 30, 2022
@sravankorumilli sravankorumilli merged commit bb61b05 into main Jun 7, 2022
@sravankorumilli sravankorumilli deleted the add-root-persistentprerun-call branch June 7, 2022 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color is not showing in all subcommands
4 participants