fix: server crash when accepting improper resource create request #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2425899844
💛 - Coveralls |
irainia
force-pushed
the
fix-create-resource-crash
branch
from
a6669ac
to
e72edc7
Compare
| @@ -442,14 +443,24 @@ func ToResourceProto(spec models.ResourceSpec) (*pb.ResourceSpecification, error | |||
| } | |||
|
|
|||
| func FromResourceProto(spec *pb.ResourceSpecification, storeName string, datastoreRepo models.DatastoreRepo) (models.ResourceSpec, error) { | |||
| if spec == nil { | |||
There was a problem hiding this comment.
@irainia cmiiw, because these flows are not handled, it is panicing and server is crashing is it? Just want to check ideally the panic should just kill the goroutine handling the request not the entire server, can we cross check on this, as this means this issue can happen even in the future for all unhandled scenarios.
There was a problem hiding this comment.
@sravankorumilli , yes, it cashed because of panic. But, we didn't explicitly call any go routine to run it (such as this).
There was a problem hiding this comment.
updated and tested based on the suggestion
|
LGTM, although seeing a similar issue on job creation. We can consider fixing that in this or new PR should also be fine. |
sravankorumilli
approved these changes
Jun 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to address #352 . Even though the issue only mentioned about resource creation, but this solution should also address the same for updating resource. This is because the update process is similar to the creation.
Changes
The followings are the changes done:
Improvement
Based on this PR, there are some TODO that can be addressed through separate cards, as the changes might be bigger.