fix: use right execution_dates to fetch airflow job runs for varying schedule intervals #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 2460876434
💛 - Coveralls |
sravankorumilli
force-pushed
the
airflow-jobruns-varying-schedules-fix
branch
from
98b37b8
to
a5bccfe
Compare
sravankorumilli
force-pushed
the
airflow-jobruns-varying-schedules-fix
branch
from
a5bccfe
to
873165d
Compare
sbchaos
reviewed
Jun 8, 2022
core/cron/cron.go
Outdated
| @@ -36,9 +36,36 @@ func ParseCronSchedule(interval string) (*ScheduleSpec, error) { | |||
| }, nil | |||
| } | |||
|
|
|||
| // Interval accepts the time and returns | |||
| func (s *ScheduleSpec) Interval(t time.Time) time.Duration { | |||
There was a problem hiding this comment.
This should be unused now, can we remove it?
sbchaos
approved these changes
Jun 8, 2022
sravankorumilli
added a commit
that referenced
this pull request
Jul 4, 2022
…schedule intervals (#396) * fix: getjobruns on varying schedules * fix: fix lint issues * refactor: remove unused code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.