Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug external sensor created when internal sensor with same urn exist #466

Merged
merged 1 commit into from
Jul 25, 2022
Merged

fix: bug external sensor created when internal sensor with same urn exist #466

merged 1 commit into from
Jul 25, 2022

Conversation

arinda-arif
Copy link
Contributor

resolving #465

@arinda-arif arinda-arif linked an issue Jul 25, 2022 that may be closed by this pull request
Bug duplicated internal and external server sensor #465
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 2730388293

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.07%) to 77.83%
Files with Coverage Reduction New Missed Lines %
ext/notify/pagerduty/pagerdutynotifier.go 2 93.75%
Totals Coverage Status
Change from base Build 2730185200: 0.07%
Covered Lines: 7681
Relevant Lines: 9869
💛 - Coveralls

@arinda-arif arinda-arif merged commit ea50e90 into main Jul 25, 2022
@arinda-arif arinda-arif deleted the fix-duplicated-internal-external-sensor branch July 25, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BitWielderSumit BitWielderSumit BitWielderSumit approved these changes

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug duplicated internal and external server sensor
4 participants
@arinda-arif @coveralls @sravankorumilli @BitWielderSumit