Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: bug unable to decode GetJobSpecificationsResponse for jobs with hook #478

Merged
merged 2 commits into from
Jul 28, 2022
Merged

fix: bug unable to decode GetJobSpecificationsResponse for jobs with hook #478

merged 2 commits into from
Jul 28, 2022

Conversation

arinda-arif
Copy link
Contributor

resolving #477

@arinda-arif @irainia
fix: bug unable to decode GetJobSpecificationsResponse for jobs with …
1dc57ff 
…hook

Co-authored-by: Anwar Hidayat <anwarhidayat14@gmail.com>
@arinda-arif arinda-arif linked an issue Jul 28, 2022 that may be closed by this pull request
bug: deployment job failure for job that has dependency to a job with hook and in other server. #477
Closed
@arinda-arif arinda-arif added bug Something isn't working and removed bug Something isn't working labels Jul 28, 2022
@coveralls
Copy link

coveralls commented Jul 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2752828534

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 77.719%
Files with Coverage Reduction New Missed Lines %
ext/notify/pagerduty/pagerdutynotifier.go 2 93.75%
Totals Coverage Status
Change from base Build 2745804253: -0.02%
Covered Lines: 7681
Relevant Lines: 9883
💛 - Coveralls

@arinda-arif @irainia
refactor: unexport adapter models in optimus resourcemgr
4d491b6 
Co-authored-by: Anwar Hidayat <anwarhidayat14@gmail.com>
@irainia
Copy link
Member

irainia commented Jul 28, 2022

LGTM, we can merge it

@arinda-arif arinda-arif merged commit 606b5d4 into main Jul 28, 2022
@arinda-arif arinda-arif deleted the fix-resourcemgr-hook-config branch July 28, 2022 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BitWielderSumit BitWielderSumit BitWielderSumit approved these changes

@irainia irainia Awaiting requested review from irainia

Assignees

@irainia irainia

@arinda-arif arinda-arif

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: deployment job failure for job that has dependency to a job with hook and in other server.
4 participants
@arinda-arif @coveralls @irainia @BitWielderSumit