Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: job_end_event trigger set to all_success #510

Merged
merged 2 commits into from
Aug 10, 2022

Conversation

Mryashbhardwaj
Copy link
Member

with trigger as all_done even after task failure , the job_end_event shall run successfully, marking the job run state as successful,

setting the trigger to all_success we can avoid that situation.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2831323501

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 75.927%

Files with Coverage Reduction New Missed Lines %
ext/notify/pagerduty/pagerdutynotifier.go 2 93.75%
Totals Coverage Status
Change from base Build 2824660058: -0.02%
Covered Lines: 7374
Relevant Lines: 9712

💛 - Coveralls

@Mryashbhardwaj Mryashbhardwaj merged commit 1216741 into main Aug 10, 2022
@Mryashbhardwaj Mryashbhardwaj deleted the job_end_event_triger_all_success branch August 10, 2022 09:16
@Mryashbhardwaj Mryashbhardwaj restored the job_end_event_triger_all_success branch August 10, 2022 09:16
Mryashbhardwaj added a commit that referenced this pull request Aug 10, 2022
* fix: set publish_job_end_event trigger to 'all_success'

* fix: set publish_job_end_event trigger to 'all_success'
Mryashbhardwaj added a commit that referenced this pull request Aug 10, 2022
* fix: set publish_job_end_event trigger to 'all_success'
@sbchaos sbchaos deleted the job_end_event_triger_all_success branch September 2, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants