Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove gorm, use pgx for postgres #696

Merged
merged 25 commits into from
Jan 5, 2023
Merged

refactor: remove gorm, use pgx for postgres #696

merged 25 commits into from
Jan 5, 2023

Conversation

sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Jan 2, 2023

No description provided.

@coveralls
Copy link

coveralls commented Jan 2, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3844192529

  • 72 of 89 (80.9%) changed or added relevant lines in 7 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 91.544%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/job/handler/v1beta1/job_adapter.go 19 23 82.61%
internal/errors/errors.go 0 5 0.0%
core/job/spec.go 34 42 80.95%
Files with Coverage Reduction New Missed Lines %
core/job/spec.go 1 95.46%
Totals Coverage Status
Change from base Build 3820861267: -0.04%
Covered Lines: 8239
Relevant Lines: 9000
💛 - Coveralls

@sbchaos sbchaos linked an issue Jan 3, 2023 that may be closed by this pull request
Migrate away from gorm, use pgx to query postgres db #592
Closed
5 tasks
@sbchaos sbchaos linked an issue Jan 3, 2023 that may be closed by this pull request
Store should fetch only the data for table and not do it for associations #421
Closed
arinda-arif and others added 5 commits January 4, 2023 10:56
@arinda-arif
fix: job repository read write issues and alter job table
defa281
@Mryashbhardwaj @irainia
fix: add scheduler repo tests (#698)
e469fe3 
* fix: bug in __lib.py due to mishandling response from handle_pod_overlap (#695)

* fix: add scheduler repo tests

Co-authored-by: Anwar Hidayat <15167551+irainia@users.noreply.github.com>
@Mryashbhardwaj
fix: fix time zone to utc
8ef3213
@Mryashbhardwaj
fix: test time zone failures
591b0d7
@arinda-arif
refactor: simplify job spec struct
534d84a
@sravankorumilli sravankorumilli merged commit 5899045 into main Jan 5, 2023
@sravankorumilli sravankorumilli deleted the remove-gorm branch January 5, 2023 06:55
@sbchaos sbchaos linked an issue Jan 10, 2023 that may be closed by this pull request
The database migration might not run in some scenarios #689
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinda-arif arinda-arif arinda-arif left review comments

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@sbchaos @coveralls @sravankorumilli @arinda-arif @Mryashbhardwaj