Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove secret type #703

Merged
merged 3 commits into from
Jan 6, 2023
Merged

refactor: remove secret type #703

merged 3 commits into from
Jan 6, 2023

Conversation

sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Jan 5, 2023

No description provided.

@coveralls
Copy link

coveralls commented Jan 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3852814814

  • 4 of 4 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 92.12%
Totals Coverage Status
Change from base Build 3852813182: -0.04%
Covered Lines: 8183
Relevant Lines: 8883
💛 - Coveralls

sravankorumilli
sravankorumilli requested changes Jan 5, 2023
View reviewed changes
internal/store/postgres/tenant/secret_repository.go Outdated Show resolved Hide resolved
core/tenant/secret.go Outdated Show resolved Hide resolved
core/tenant/secret.go Show resolved Hide resolved
@sravankorumilli sravankorumilli merged commit 794803c into main Jan 6, 2023
@sravankorumilli sravankorumilli deleted the remove-secret-type branch January 6, 2023 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbchaos @coveralls @sravankorumilli