Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: duplicated upstream issue & job BC unclear logs #719

Merged
merged 16 commits into from
Jan 17, 2023
Merged

fix: duplicated upstream issue & job BC unclear logs #719

merged 16 commits into from
Jan 17, 2023

Conversation

arinda-arif
Copy link
Contributor

@arinda-arif arinda-arif commented Jan 11, 2023 •
edited
Loading

  • fixing Static and inferred downstream job creates duplicate sensor #715
  • remove inaccurate logs saying upstream resolved externally while in fact there is no external optimus registered
  • improve logs in external upstream resolver by adding namespace prefix
  • improve logs when static upstream is specified but empty
  • improve logs when unable to delete jobs while doing replace all

@coveralls
Copy link

coveralls commented Jan 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 3936177886

  • 46 of 49 (93.88%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 92.11%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/job/spec.go 0 1 0.0%
core/job/resolver/upstream_resolver.go 2 4 50.0%
Totals Coverage Status
Change from base Build 3935897360: 0.008%
Covered Lines: 8371
Relevant Lines: 9088
💛 - Coveralls

@arinda-arif arinda-arif marked this pull request as draft January 13, 2023 07:31
@arinda-arif arinda-arif changed the title fix: incomplete job logs on upstream resolver fix: job bounded context unclear logs Jan 13, 2023
@arinda-arif arinda-arif changed the title fix: job bounded context unclear logs fix: duplicated upstream issue & job BC unclear logs Jan 16, 2023
@arinda-arif arinda-arif marked this pull request as ready for review January 16, 2023 07:07
@arinda-arif arinda-arif linked an issue Jan 16, 2023 that may be closed by this pull request
Static and inferred downstream job creates duplicate sensor #715
Closed
sravankorumilli
sravankorumilli requested changes Jan 16, 2023
View reviewed changes
Copy link
Contributor

@sravankorumilli sravankorumilli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added comments

@arinda-arif
Copy link
Contributor Author

@sravankorumilli please check the recent changes:

  • deduplicating from the root (for bulk resolve cases in the repository layer, for single resolve cases after merging static & inferred). the second deduplication is the same, after merging the unresolved with resolved ones.
  • supports deduplicating unresolved upstreams

@arinda-arif arinda-arif merged commit cdcb2be into main Jan 17, 2023
@arinda-arif arinda-arif deleted the fix-job-logs branch January 17, 2023 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sravankorumilli sravankorumilli sravankorumilli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Static and inferred downstream job creates duplicate sensor
3 participants
@arinda-arif @coveralls @sravankorumilli