Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: simplify fetching of secrets for compilation #735

Merged
merged 1 commit into from
Feb 10, 2023
Merged

refactor: simplify fetching of secrets for compilation #735

merged 1 commit into from
Feb 10, 2023

Conversation

sbchaos
Copy link
Contributor

@sbchaos sbchaos commented Feb 9, 2023

No description provided.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4134399658

  • 23 of 24 (95.83%) changed or added relevant lines in 5 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.04%) to 92.079%
Changes Missing Coverage Covered Lines Changed/Added Lines %
core/job/service/plugin_service.go 7 8 87.5%
Files with Coverage Reduction New Missed Lines %
core/job/service/plugin_service.go 1 92.37%
Totals Coverage Status
Change from base Build 4122075803: 0.04%
Covered Lines: 8439
Relevant Lines: 9165
💛 - Coveralls

@sravankorumilli sravankorumilli merged commit c4cf585 into main Feb 10, 2023
@sravankorumilli sravankorumilli deleted the simplify-compilation branch February 10, 2023 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sbchaos @coveralls @sravankorumilli