Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable entrypoint for kubernetes pod executor #740

Merged
merged 8 commits into from
Feb 24, 2023
Merged

feat: configurable entrypoint for kubernetes pod executor #740

merged 8 commits into from
Feb 24, 2023

Conversation

deryrahman
Copy link
Member

@deryrahman deryrahman commented Feb 13, 2023 •
edited
Loading

  • entrypoint to print the plugin configs
  • patch for plugin validation

@deryrahman deryrahman force-pushed the config-sourcing-on-executor-container branch from f98c18e to 540c69b Compare February 14, 2023 07:18
@coveralls
Copy link

coveralls commented Feb 14, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4249249625

  • 9 of 9 (100.0%) changed or added relevant lines in 3 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 92.12%
Files with Coverage Reduction New Missed Lines %
core/scheduler/service/job_run_service.go 10 93.91%
Totals Coverage Status
Change from base Build 4141290951: 0.09%
Covered Lines: 8370
Relevant Lines: 9086
💛 - Coveralls

smarchint
smarchint reviewed Feb 22, 2023
View reviewed changes
ext/scheduler/airflow/dag/dag.py.tmpl Outdated Show resolved Hide resolved
sdk/plugin/plugin.go Show resolved Hide resolved
ext/scheduler/airflow/dag/dag.py.tmpl Outdated Show resolved Hide resolved
ext/scheduler/airflow/dag/dag.py.tmpl Show resolved Hide resolved
smarchint
smarchint approved these changes Feb 23, 2023
View reviewed changes
Copy link
Member

@smarchint smarchint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deryrahman deryrahman merged commit e96ca18 into main Feb 24, 2023
@deryrahman deryrahman deleted the config-sourcing-on-executor-container branch February 24, 2023 03:43
sravankorumilli pushed a commit that referenced this pull request Feb 27, 2023
@deryrahman @sravankorumilli
feat: configurable endpoint for kubernetes pod executor (#740)
c42e0c9 
* feat: add entrypoint feature on plugins

* remove: fetch env and secret from api

* feat: return info with entrypoint

* remove: unecessary param on dag template

* test: fix test

* refactor: use get entrypoint func

* feat: make entrypoint as required

* feat: validate plugin yaml info
@smarchint smarchint changed the title feat: configurable endpoint for kubernetes pod executor feat: configurable entrypoint for kubernetes pod executor Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarchint smarchint smarchint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@deryrahman @coveralls @smarchint