-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Commit guidlines #91
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used these resources as examples.. may need to rewrite ourselves to not steal their work. https://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes https://github.com/eslint/eslint-github-bot/blob/master/docs/commit-message-check.md
used these resources as examples.. may need to rewrite ourselves to not steal their work. https://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes https://github.com/eslint/eslint-github-bot/blob/master/docs/commit-message-check.md https://github.com/eslint/eslint-github-bot https://github.com/probot/probot
nathanleviere
requested review from
adamkingit,
dalehille,
mckaymic,
rmgraham and
yingwang-us
April 1, 2020 17:41
dalehille
approved these changes
Apr 2, 2020
adamkingit
reviewed
Apr 2, 2020
adamkingit
approved these changes
Apr 2, 2020
alewitt2
changed the title
Do Not Merge: Commit guidlines
Do Not Merge: Docs: Commit guidlines
Apr 2, 2020
alewitt2
changed the title
Do Not Merge: Docs: Commit guidlines
Do Not Merge | Docs: Commit guidlines
Apr 2, 2020
mckaymic
approved these changes
Apr 15, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 This looks good. I'm excited for it.
rmgraham
approved these changes
Apr 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
used these resources as examples.. may need to rewrite ourselves to not steal their work.
https://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes
https://github.com/eslint/eslint-github-bot/blob/master/docs/commit-message-check.md
https://github.com/eslint/eslint-github-bot
https://github.com/probot/probot
useful command for generating release descriptions
or a one line option to get the pretty print between HEAD and the latest release