Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Commit guidlines #91

Merged
merged 8 commits into from
May 6, 2020
Merged

Docs: Commit guidlines #91

merged 8 commits into from
May 6, 2020

Conversation

alewitt2
Copy link
Member

@alewitt2 alewitt2 commented Mar 11, 2020

used these resources as examples.. may need to rewrite ourselves to not steal their work.
https://eslint.org/docs/developer-guide/contributing/pull-requests#step-2-make-your-changes
https://github.com/eslint/eslint-github-bot/blob/master/docs/commit-message-check.md
https://github.com/eslint/eslint-github-bot
https://github.com/probot/probot

useful command for generating release descriptions

git checkout master
git pull origin
export NUM_COMMITS=5
git log --pretty=format:"[\`%h\`](https://github.com/razee-io/$(basename $(git rev-parse --show-toplevel))/commit/%H) %s" -"${NUM_COMMITS}"

or a one line option to get the pretty print between HEAD and the latest release

git log --pretty=format:"[\`%h\`](https://github.com/razee-io/$(basename $(git rev-parse --show-toplevel))/commit/%H) %s" HEAD..."$(curl --silent https://api.github.com/repos/razee-io/$(basename $(git rev-parse --show-toplevel))/releases/latest | jq -r .target_commitish)" | pbcopy

@alewitt2 alewitt2 added the enhancement New feature or request label Mar 11, 2020
@alewitt2 alewitt2 self-assigned this Mar 11, 2020
@alewitt2 alewitt2 changed the title Do Not Merge: Commit guidlines Do Not Merge: Docs: Commit guidlines Apr 2, 2020
@alewitt2 alewitt2 changed the title Do Not Merge: Docs: Commit guidlines Do Not Merge | Docs: Commit guidlines Apr 2, 2020
Copy link
Contributor

@mckaymic mckaymic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 This looks good. I'm excited for it.

@alewitt2 alewitt2 merged commit 7a652bb into master May 6, 2020
@alewitt2 alewitt2 deleted the commit-guidlines branch May 6, 2020 13:38
@alewitt2 alewitt2 changed the title Do Not Merge | Docs: Commit guidlines Docs: Commit guidlines May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants