-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: hideClearButton Prop to SearchInput Component #2433
base: master
Are you sure you want to change the base?
Conversation
|
✅ PR title follows Conventional Commits specification. |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3cf5439:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @yadavshubham01,
Thanks for raising this PR
Could you add a test case for hideClearButton? Also, there is one thin one test case is failing. Please pull the latest changes from the master branch, I think it will resolve the issue. Other than that, there are a few linting errors. Could you fix them as well?
packages/blade/src/components/Input/SearchInput/SearchInput.tsx
Outdated
Show resolved
Hide resolved
packages/blade/src/components/Input/SearchInput/SearchInput.stories.tsx
Outdated
Show resolved
Hide resolved
packages/blade/src/components/Input/SearchInput/SearchInput.tsx
Outdated
Show resolved
Hide resolved
@yadavshubham01 GitHub Actions still seem to be failing. Can you lint the code once locally? |
let me fix the linting in code |
4b6b32c
to
3cf5439
Compare
hey @tewarig I fix linting now you checked it |
@yadavshubham01 can you add changeset ? |
No |
This pull request introduces a new prop, hideClearButton, to the SearchInput component. This prop allows users to control the visibility of the clear button in the input field, enhancing the component's flexibility for various use cases.
Changes Made:
Created new stories to demonstrate the functionality of the hideClearButton prop.
Included examples for both scenarios: with the clear button visible and hidden.
Documentation: Updated the component documentation to include details about the new prop and its usage.
Related Issues
#2377