[fix][client] Add support to TableView to read encrypted messages #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… TableView - CryptoKeyReader is added to TableViewConfigurationData - when the Reader inside the TableView is being built, add it in case it is not null
- by default, this action is set to ConsumerCryptoFailureAction.FAIL - added to the reader when the TableView is being built
6 tasks
|
The pr had no activity for 30 days, mark with Stale label. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache#19007
Motivation
This PR adds support for a
TableViewto read encrypted messages from a topic.Modifications
Analogous to
ReaderBuilder, I've added methods toTableViewBuilderthat allow to specify aCryptoKeyReaderand aConsumerCryptoFailureAction. The respective values are stored inTableViewConfigurationDataand forwarded to theReaderBuilderinstance insideTableViewImplwhen theReaderis constructed.Verifying this change
This change added tests and can be verified as follows:
TableViewImplandTableViewBuilderImplTableViewDoes this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes
Documentation
docdoc-requireddoc-not-neededdoc-complete