Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is Setup() supposed to cleanup layout? #115

Closed
ray-x opened this issue Jun 30, 2022 · 2 comments
Closed

Is Setup() supposed to cleanup layout? #115

ray-x opened this issue Jun 30, 2022 · 2 comments

Comments

@ray-x
Copy link

ray-x commented Jun 30, 2022

image

From what I see, if

  1. call dapui.setup()
  2. call daupui.open()
  3. call dapui.setup() again without close the dapui windows
  4. check layout is open with layout:is_open()

step 4 will return false even though the UI is not closed. From the logs, opened_wins = {} So I suspect setup() cleanup the opened_wins without destroy them.

There are no places mentioned setup() should be called only once.

Maybe before setup() cleanup everything, put some error messages if there are still opened windows.

@ray-x ray-x changed the title Setup() should cleanup layout? Is Setup() supposed to cleanup layout? Jun 30, 2022
rcarriga added a commit that referenced this issue Jul 2, 2022
@rcarriga
Copy link
Owner

rcarriga commented Jul 2, 2022

It is not designed to be called twice but I've added a change to clear the layouts if it does happen.

@ray-x
Copy link
Author

ray-x commented Jul 2, 2022

Thanks!

@ray-x ray-x closed this as completed Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants