Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text is inserted when calling eval after editting value #250

Closed
jamestansx opened this issue Mar 16, 2023 · 4 comments
Closed

Text is inserted when calling eval after editting value #250

jamestansx opened this issue Mar 16, 2023 · 4 comments

Comments

@jamestansx
Copy link

jamestansx commented Mar 16, 2023

Perhaps the title is not clear enough, I have also provided a video demo.

When calling eval and edit the variable inside the floating window (with key e), calling eval the second time will cause weird behavior where the same word under cursor will be inserted and will change to insert mode.

output_file.mov
@Nosterx
Copy link

Nosterx commented Mar 18, 2023

Same here.
Kazam_screencast_00009.webm

@KrzysztofJopek
Copy link

Looks like the issue was introduced in 6f18751
From a short debugging session, I found that prompt_fill is not being cleared.
Inserting prompt_fill = nil after async.run() fixes the problem for me, but I have zero Lua knowledge, so I don't know what is the real effect.

@rcarriga
Copy link
Owner

Should be fixed in latest master 😄 It was a bad assumption that the current buffer was the buffer being rendered

@jamestansx
Copy link
Author

Tested, it's all good now! Thanks for the fix! 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants