-
-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Controls not re-rendering until cursor enters or exits controls window #251
Comments
The controls use the |
I have this same problem too. After using bisect, I've found that it's commit 5c572cd (or the one before that, from what i see this commit here fixed the issue of the previous commit) that caused the issue. Hope that helps. |
I'm using LazyVim so I checked that my personal config is not setting When I have some time, I'll try to repro on |
I was able to reproduce this with a clean LazyVim installation on Neovim 0.9 and adding one file for configuring dap. Notice that debugging is paused at line 6, but the controls look like: I expected them instead to look like: If my cursor enters the controls window (either by clicking or using window navigation keymaps), then the controls redraw correctly. Also, not sure if the row highlight is meant to be on the same row as the controls, or if its intentional that that next row after the controls is highlighted. Config-- ~/.config/nvim/lua/plugins/dap.lua
return {
{
"mfussenegger/nvim-dap",
dependencies = {
"rcarriga/nvim-dap-ui",
"mxsdev/nvim-dap-vscode-js",
{
"microsoft/vscode-js-debug",
opt = true,
build = "npm install --legacy-peer-deps && npx gulp vsDebugServerBundle && mv dist out",
},
},
config = function()
local dap = require("dap")
local dapui = require("dapui")
dapui.setup()
dap.listeners.after.event_initialized["dapui_config"] = dapui.open
dap.listeners.before.event_terminated["dapui_config"] = dapui.close
dap.listeners.before.event_exited["dapui_config"] = dapui.close
local lazy_path = vim.fn.glob(vim.fn.stdpath("data") .. "/lazy/")
require("dap-vscode-js").setup({
debugger_path = lazy_path .. "vscode-js-debug",
adapters = { "pwa-node", "pwa-chrome", "pwa-msedge", "node-terminal", "pwa-extensionHost" },
})
for _, language in ipairs({ "typescript", "javascript" }) do
dap.configurations[language] = {
{
type = "pwa-node",
request = "launch",
name = "Launch file",
program = "${file}",
cwd = "${workspaceFolder}",
-- https://github.com/microsoft/vscode/issues/102042
resolveSourceMapLocations = {
"${workspaceFolder}/**",
"!**/node_modules/**",
},
},
}
end
end,
},
} I also have one file to patch -- ~/.config/nvim/lua/plugins/treesitter.lua
-- In nvim 0.9, `help` was renamed to `vimdoc`, but `LazyVim` hasn't been updated for that yet.
-- This patch ensures you don't see a warning/error about `help` language stuff not being installed when `nvim` is launched.
return {
"nvim-treesitter/nvim-treesitter",
opts = function(_, opts)
opts.ignore_install = { "help" }
if type(opts.ensure_installed) == "table" then
vim.list_extend(opts.ensure_installed, {
"vimdoc",
})
end
end,
} |
Note: I haven't gone through the effort of disabling LazyVim's built-in plugins one-by-one to track down if any of them are interfering here. Nor have I tried to reproduce this without LazyVim installed at all. If I have more time, then I might try to narrow this down further. |
I was able to reproduce this, it was introduced by a recent refactor. Should be working now 😄 |
@rcarriga just tested it out, and looks like the controls are redrawing correctly now! Potentially related: Is it intentional that the highlighted row is below the controls? I would have expected the row with the controls to be highlighted, not the one after. |
That's not a dapui feature. I believe that's because your |
Controls do not rerender until I click or my cursor enters the controls window.
Video repro: https://youtu.be/D3GB6h4UDkg
Config
Full config: https://github.com/pcattori/nvim/blob/main/lua/plugins/dap.lua
The text was updated successfully, but these errors were encountered: