Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(resolve_qualified_name): null pointer when package is empty #167

Merged
merged 1 commit into from
Nov 19, 2024
Merged

fix(resolve_qualified_name): null pointer when package is empty #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions lua/neotest-java/util/resolve_qualified_name.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,9 @@ local function resolve_qualified_name(filename)
((class_declaration (identifier) @target))
]]

local package_line = find_in_text(package_query, content)[1]
local package_lines = find_in_text(package_query, content)

local package_line = (package_lines and package_lines[1]) and (package_lines[1] .. ".") or ""
local names = find_in_text(class_name_query, content)

-- as there can be different class names
Expand All @@ -54,7 +56,7 @@ local function resolve_qualified_name(filename)
end
end

return package_line .. "." .. name
return package_line .. name
end

return resolve_qualified_name
6 changes: 6 additions & 0 deletions tests/util/resolve_qualified_name_spec.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,12 @@ describe("resolve_qualified_name", function()
]],
expected = "com.example.ExampleTest",
},
{
input = [[
class ExampleTest {}
]],
expected = "ExampleTest",
},
}

for _, case in ipairs(testcases) do
Expand Down