Skip to content

Commit

Permalink
Ensure that js-plugins aren't cached (deephaven#4621)
Browse files Browse the repository at this point in the history
This is an oversight discovered by web team and should have been part of deephaven#4389.

Added deephaven#4620 as eventual follow-up.
  • Loading branch information
devinrsmith authored Oct 12, 2023
1 parent a55a2ab commit 9ab5065
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,8 @@ public JettyBackedGrpcServer(
context.addFilter(new FilterHolder(filter), "/*", EnumSet.noneOf(DispatcherType.class));

// Wire up /js-plugins/*
// TODO(deephaven-core#4620): Add js-plugins version-aware caching
context.addFilter(NoCacheFilter.class, JS_PLUGINS_PATH_SPEC, EnumSet.noneOf(DispatcherType.class));
context.addServlet(servletHolder("js-plugins", jsPlugins.filesystem()), JS_PLUGINS_PATH_SPEC);

// Set up websockets for grpc-web - depending on configuration, we can register both in case we encounter a
Expand Down

0 comments on commit 9ab5065

Please sign in to comment.