Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JNI support with CI workflow #9

Merged
merged 6 commits into from
Aug 14, 2022
Merged

JNI support with CI workflow #9

merged 6 commits into from
Aug 14, 2022

Conversation

tgrospic
Copy link
Collaborator

@tgrospic tgrospic commented Aug 13, 2022

Overview

This PR adds JNI support to compilation of native code for https://github.com/bitcoin-core/secp256k1.

JNI files are taken from PR which removed support on the source repo.
bitcoin-core/secp256k1#682

Also files are updated from the PR on https://github.com/bitcoin-s/bitcoin-s repo which also uses original source.
bitcoin-s/secp256k1-zkp@17ab106 (PR bitcoin-s/secp256k1-zkp#1)

Also fix for macOS for JDK path is taken from @nzpr's build.
nzpr/secp256k1@41fa378

GitHub CI workflow

GitHub workflow CI files are added with support for bors. Running examples can be seen on the fork repo.
https://github.com/tgrospic/secp256k1-native/actions/runs/2851923440

TODO

Makefile and configure are for now copied as a whole files, but later only changes should be extracted to a script of diff file to update originals.

What's missing is support for multiple architecture e.g. ARM and CI action to create releases.

@tgrospic tgrospic force-pushed the jni-ci branch 16 times, most recently from 8867316 to fdee0d7 Compare August 13, 2022 11:55
@tgrospic
Copy link
Collaborator Author

bors try

bors bot added a commit that referenced this pull request Aug 13, 2022
@@ -0,0 +1,241 @@
.PHONY: clean-precomp precomp
Copy link
Collaborator

@nzpr nzpr Aug 13, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to have a patch for original Makefile here instead of rewriting the whole file? Same for configure.ac

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an initial version with the copy of the whole files. Changes should be extracted to a script or diff file.

@tgrospic
Copy link
Collaborator Author

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 14, 2022

Build succeeded:

@bors bors bot merged commit b6e85f1 into rchain:master Aug 14, 2022
@bors
Copy link
Contributor

bors bot commented Aug 14, 2022

try

Timed out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants