Updates from debugpy to get debugpy tests to pass #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchiodo
commented
Sep 18, 2024
| @@ -26,6 +26,7 @@ | |||
| GUI_QT = "qt" | |||
| GUI_QT4 = "qt4" | |||
| GUI_QT5 = "qt5" | |||
| GUI_QT6 = "qt6" | |||
There was a problem hiding this comment.
All the changes in this directory were changes made in Debugpy before I started this work, so this directory can be ignored.
AdamYoblick
reviewed
Sep 19, 2024
| if not _is_user_frame(frame): | ||
| return False | ||
|
|
||
| # If this frame is the last frame, then it is the last one |
AdamYoblick
approved these changes
Sep 19, 2024
rchiodo
added a commit
to microsoft/debugpy
that referenced
this pull request
Sep 23, 2024
This is pulling in @fabioz's latest changes for sys.monitoring and then fixing up any issues found with the debugpy tests. A lot of the changes were made by Fabio since the latest pull from pydevd, so I also created this PR to compare what changes I made to Fabio's baseline: rchiodo/PyDev.Debugger#1 Meaning you really only need to look at that other PR to see what changes I made. The rest of the changes here are from Fabio or ruff doing reformating. After this goes through, we should have sys.monitoring support in debugpy. We can decide later if we want to implement our own support as @int19h started. Fixes #1496
…PyDev.Debugger into rchiodo/debugpy_updates
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a diff between what I want to submit into Debugpy for sys.monitoring support and what PyDev.Debugger currently has.
The tests will fail here but main is failing for PyDev.Debugger anyway.