Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

user-activity #275

Merged
merged 10 commits into from
Sep 20, 2024
Merged

user-activity #275

merged 10 commits into from
Sep 20, 2024

Conversation

eatyourpeas
Copy link
Member

@eatyourpeas eatyourpeas commented Sep 15, 2024 •
edited
Loading

Overview

The PR updates the VisitActivity model with some new activities
These include:

ACTIVITY = (
        (SUCCESSFUL_LOGIN, "Successful login"),
        (UNSUCCESSFUL_LOGIN, "Login failed"),
        (LOGOUT, "Logout"),
        (PASSWORD_RESET_LINK_SENT, "Password reset link sent"),
        (PASSWORD_RESET, "Password reset successfully"),
        (PASSWORD_LOCKOUT, "Password lockout"),
        (SETUP_TWO_FACTOR_AUTHENTICATION, "Two factor authentication set up"),
        (UPLOADED_CSV, "Uploaded CSV"),
        (TOUCHED_PATIENT_RECORD, "Touched patient record"),
    )

These have all been implemented apart from the last one.
These are all reflected in the user logs table as well as inclusion of account creation date which was an unused field in the user model
Users are now locked out for 5 minutes if they attempt to login more than 5 times in a row. This is a feature requested in the pen testing for E12.
Also, the patient table signposts more clearly if the view is national or PDU.

Documentation changes (done or required as a result of this PR)

The user documentation relating to passwords and account creation has been updated

Related Issues

fixes #267

@eatyourpeas
add pz code to submission table for superusers
64a216c
@eatyourpeas
hide delete button from active submissions
b467f5b
@eatyourpeas
add new activities to VisitActivity and more readable message in table
1e2edd1
@eatyourpeas
update visitactivity to record password reset link and successful pas…
53c4956 
…sword reset

bug fix - password_last_reset previously resent when email sent, now updated when actually reset
@eatyourpeas
update documentation for users on passwords and login
8f18699 
remove password reset for logged in users
activate lockout for 5 minutes with 5 failed logins
store this in visit activity
@eatyourpeas
add 2fa signals - can't test in development
f0688e3
@eatyourpeas
wire up date_joined date in user model
99e42ce 
report date_joined in user logs table
@eatyourpeas
store csv upload in VisitActivity
3e9ad65
@eatyourpeas
signpost update patient list to toggle between national/PDU in template
1cf8a6d
@eatyourpeas
trap failed to save csv_upload at activity in error logs
9558367
@eatyourpeas
Copy link
Member Author

eatyourpeas commented Sep 15, 2024 •
edited
Loading

This gives an idea of what it adds.
image

@eatyourpeas
Copy link
Member Author

#276 by the way arose during development here so posting here to highlight

@eatyourpeas eatyourpeas mentioned this pull request Sep 15, 2024
Closed
@mbarton mbarton merged commit 9a0c9e0 into live Sep 20, 2024
1 check passed
@mbarton mbarton deleted the eatyourpeas/issue267 branch September 20, 2024 09:43
@mbarton
Copy link
Member

mbarton commented Sep 20, 2024

Seen on STAGING (created by @eatyourpeas and merged by @mbarton 5 minutes and 22 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbarton mbarton mbarton approved these changes

Assignees
No one assigned
Labels
Seen-on-STAGING
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit-level event log of file uploads
2 participants
@eatyourpeas @mbarton