LHC-189 #72
Merged
LHC-189 #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… name on ticket view
jonmak08
reviewed
Apr 10, 2019
|
|
||
| const orgNamePlaceholder = document.getElementById('orgNamePlaceholder'); | ||
|
|
||
| orgNamePlaceholder.innerHTML = orgName; |
There was a problem hiding this comment.
We should check to make sure orgNamePlaceholder is not null or undefined.
There was a problem hiding this comment.
orgNamePlaceholder is a div in the template. Even if a Zendesk Curlybar helper were to fail, that div would still get rendered. Do we still need to null check?
There was a problem hiding this comment.
I would do it as a fail safe for the JS side just in case someone removed it accidentally or something happened further down the line which they were unaware of the ramifications. Always better to be safe than sorry with a simple check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://issues.liferay.com/browse/LHC-189
Due to the way the Zendesk Customization is set, customers for a long project name are not able to view the full project name. To get around that, the team decided to grab the value from the dropdown and hide it. Then display that value separately as text. That way the text will naturally wrap and allow the customer to see the entire organization name.