Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switchable Analytics fix (final, I hope) #11

Merged
merged 10 commits into from
Oct 24, 2022
Merged

Switchable Analytics fix (final, I hope) #11

merged 10 commits into from
Oct 24, 2022

Conversation

rdavydov
Copy link
Owner

Description

enable_analytics option in twitch_minerfile toggles Analytics needed for the analytics() method

Disabling Analytics significantly reduces memory consumption and saves some disk space by not creating and writing /analytics/*.json.

Set this option to True if you need Analytics. Otherwise set this option to False (default value).

See example.py. If no such option - defaults to False.

Fixes #2, #10

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

From tests that I've done on my Windows 10 PC - it reduces memory consumption significantly - from 800 MB with analytics enabled to 40 MB with disabled. On my Linux boxes it also becomes less memory-hungry.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md)
  • My changes generate no new warnings
  • Any dependent changes have been updated in requirements.txt

@rdavydov rdavydov merged commit 0a523b3 into master Oct 24, 2022
@justejules justejules mentioned this pull request Sep 25, 2023
lyw1217 pushed a commit to lyw1217/Twitch-Channel-Points-Miner-v2 that referenced this pull request Nov 5, 2023
Switchable Analytics fix (final, I hope)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐜 bug Something isn't working 🧱 enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switchable Analytics, Discord, Telegram
1 participant