mono mode to pause the rainbow #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Now using node 20 in .nvmrc from now on eleventeen support focuses on the active node LTS here: https://github.com/nodejs/Release/blob/main/README.md#release-schedule
rainbutton will not display when JS is disabled, since it would not work
you cannot stop the rainbow. but sometimes you need to pause it. - add mono option to disable rainbow mode features in eleventeen - docs: + attempt to make emoji in readme and site more accessible thanks Rachel Leggett https://devyarns.com/accessible-emojis/ and Beth Finke https://blog.easterseals.com/emojis-and-accessibility-the-dos-and-donts-of-including-emojis-in-texts-and-emails/ + document MONO MODE in README.md ```diff --- a/README.md +++ b/README.md +Here in the world of eleventeen, rainbow is the default. But we acknowledge not all sites are a match for Rainbow Mode, and still want those sites to enjoy the rest of what eleventeen has to offer, so [v9.2.3-alpha.5](https://github.com/rdela/eleventeen/releases/tag/v9.2.3-alpha.5), adds a `mono` option to [`_data/metadata.js`](_data/metadata.js) that will disable Rainbow Mode if you set it to `true`. `mono` is `false` by default, on purpose, because it beats making people set an option called `rainbow` to `false` and might make the current `{%- if not metadata.mono %}` template logic in [`_includes/layouts/base.njk`](_includes/layouts/base.njk) a little more resilient. ```
✅ Deploy Preview for eleventeen ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
you cannot stop the rainbow. but sometimes you need to pause it.
add mono option to disable rainbow mode features in eleventeen
docs:
attempt to make emoji in readme and site more accessible
thanks Rachel Leggett https://devyarns.com/accessible-emojis/
and Beth Finke https://blog.easterseals.com/emojis-and-accessibility-the-dos-and-donts-of-including-emojis-in-texts-and-emails/
document MONO MODE in README.md