add @daviddarnes/heading-anchors #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least until [#40](#40) finds resolution, building on the work in [#39](#39), adding [daviddarnes/heading-anchors](https://github.com/daviddarnes/heading-anchors) per rec in [11ty/eleventy #3363](11ty/eleventy#3363) Used `position="beforeend"` and styled with a slight adjustment to [demo-styling], adding `vertical-align: bottom;` to `a[href^="#"]` and constraining styles to `heading-anchors` element. demo-styling: https://github.com/daviddarnes/heading-anchors/blob/main/demo-styling.html#L11-L25
✅ Deploy Preview for eleventeen ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- add hover + focus styles - 9.2.21-alpha.17 - delete deprecated css
|
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
Having heading-anchors on the base template makes it work on pages as well.
|
rdela
added a commit
that referenced
this pull request
Jul 25, 2024
* add @daviddarnes/heading-anchors At least until #40 finds resolution, building on the work in #39 adding https://github.com/daviddarnes/heading-anchors per rec in 11ty/eleventy#3363 Used `position="beforeend"` and styled with a slight adjustment to https://github.com/daviddarnes/heading-anchors/blob/main/demo-styling.html#L11-L25 adding `vertical-align: bottom;` to `a[href^="#"]` and constraining styles to `heading-anchors` element. * move heading-anchors code to base.njk instead of post.njk - add hover + focus styles for anchor links - delete deprecated css
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least until #40 finds resolution, building on the work in
#39, adding daviddarnes/heading-anchors per rec in 11ty/eleventy #3363
Used
position="beforeend"and styled with a slight adjustment to demo-styling, addingvertical-align: bottom;toa[href^="#"]and constraining styles toheading-anchorselement.