Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(NavigationManager): fix render order and storybook glitches #468

Merged
merged 17 commits into from
Feb 29, 2024
Merged

fix(NavigationManager): fix render order and storybook glitches #468

merged 17 commits into from
Feb 29, 2024

Conversation

ChrisArasin
Copy link
Contributor

@ChrisArasin ChrisArasin commented Feb 16, 2024 •
edited
Loading

Description

  • Allows NavigationManager children components to run layout/updates before the parent does. This prevents a mis-rendered stack of children on the first render of column/row.
  • Also includes Storybook render glitch fixes to normalize storybook rendering. These changes are described here: fix(Storybook): set theme and props before render #465
  • It helps to evaluate this PR, but we can merge separately or all together here.
  • Fixes the use of the centerKeys prop in keyboard to fix a mis-rendered first draw.

References

Related to: LUI-1328

Testing

  • Ensure Column/Row based layouts are functioning properly. Items should draw in place and not stacked on top of each other when chrome is throttled down.

Checklist

  • all commented code has been removed
  • any new console issues have been resolved
  • code linter and formatter has been run
  • test coverage meets repo requirements
  • PR name matches the expected semantic-commit syntax

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

5 similar comments
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ChrisArasin ChrisArasin force-pushed the fix/column-stacking-smaller branch from 6cfa89e to 5d1d1a8 Compare February 19, 2024 15:54
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

2 similar comments
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

1 similar comment
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight
Copy link
Contributor

All the stories I tested are looking good, but I did see that the TextPanel portion of GridOverlay still has a Column that is showing the TextBoxes stacked when first rendering:

Screen.Recording.2024-02-20.at.9.44.15.AM.mov

@ChrisArasin
Copy link
Contributor Author

All the stories I tested are looking good, but I did see that the TextPanel portion of GridOverlay still has a Column that is showing the TextBoxes stacked when first rendering:

So this would be an example of where waitForDimensions may still be relevant. In this case, the items don't have a height until the text textures are rendered and the textboxes update. If they had a height set beforehand, then would not stack

@ChrisArasin ChrisArasin force-pushed the fix/column-stacking-smaller branch from b402236 to 31549c8 Compare February 20, 2024 17:24
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight ImCoolNowRight force-pushed the fix/column-stacking-smaller branch from 3fa1dfb to 24bb9b0 Compare February 29, 2024 19:27
ChrisArasin and others added 17 commits February 29, 2024 14:46
@ChrisArasin @ImCoolNowRight
fix(NavigationManager): bottom up children layouts
5b661b8
@ChrisArasin @ImCoolNowRight
fix(Keyboard): doesn't need waitForDimensions and fix centerKeys
83b2f85 
fix(Keyboard): centerkeys used properly
@ChrisArasin @ImCoolNowRight
fix(FocusManager): fix jank on skip focused first element
5773fc5
@ChrisArasin @ImCoolNowRight
chore(Snapshots): update snapshots
9be93bf
@ChrisArasin @ImCoolNowRight
chore(withUpdates): add requestEarlyUpdate test
adde0a2
@ChrisArasin @ImCoolNowRight
chore(withUpdates): additional tests
3e35025
@ChrisArasin @ImCoolNowRight
fix(NavigationManager): additional guard before extra updateLayout call
1231451
@ChrisArasin @ImCoolNowRight
chore(GlobalUpdateManager): hasQueuedRequestFor tests
94be061
@ChrisArasin @ImCoolNowRight
fix(NavigationManager): appended items should immediately update
51c1bf5
@ChrisArasin @ImCoolNowRight
chore(GridOverlay): update snapshot
303ee47
@ChrisArasin @ImCoolNowRight
chore(Row): fix onScreenEffect test
5350894
@ChrisArasin @ImCoolNowRight
fix(NavigationManager): optimize appendLazyItem perf
9dabd67
@ChrisArasin @ImCoolNowRight
fix(FocusManager): clear _lazyItems on set items
2d96507
@ChrisArasin @ImCoolNowRight
fix(FocusManager): rename selectNext(shouldSmoothOverride) and add to…
1bdfde3 
… mdx docs
@ChrisArasin @ImCoolNowRight
fix(NavigatioManager): rename shouldStopSmooth to shouldSmoothOverride
2073b72
@ImCoolNowRight
fix(Keyboard): update snapshots
baeb96b
@ImCoolNowRight
fix(FocusManager): comment lazyItems fix
79fa372
@ImCoolNowRight ImCoolNowRight force-pushed the fix/column-stacking-smaller branch from 24bb9b0 to 79fa372 Compare February 29, 2024 19:46
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

1 similar comment
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

@ImCoolNowRight ImCoolNowRight merged commit a90457a into develop Feb 29, 2024
9 checks passed
@ImCoolNowRight ImCoolNowRight deleted the fix/column-stacking-smaller branch February 29, 2024 20:09
@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

svc-lightning-ui-components pushed a commit that referenced this pull request Feb 29, 2024
@semantic-release-bot
chore(release): 2.20.3 [skip ci]
4a9c28a 
# [@lightningjs/ui-components-v2.20.3](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.20.2...@lightningjs/ui-components-v2.20.3) (2024-02-29)

### Bug Fixes

* **ControlRow:** fix right controls to use lazyScrolling too ([#480](#480)) ([9717848](9717848))
* **NavigationManager:** check an items render size before its set width or height for layout (important for Tiles using metadata underneath) ([#479](#479)) ([40d2e21](40d2e21))
* **NavigationManager:** fix render order and storybook glitches ([#468](#468)) ([a90457a](a90457a))
* **NavigationManager:** if an itemPosX or itemPosY are set, apply offset to scrolling ([#477](#477)) ([a02cf12](a02cf12))
* **TitleRow:** move title props to separate getter for easier extension of other components ([#478](#478)) ([ad34043](ad34043))
@svc-lightning-ui-components
Copy link
Collaborator

🎉 This PR is included in version @lightningjs/ui-components-v2.20.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@svc-lightning-ui-components
Copy link
Collaborator

Test Execution Failed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erautenberg erautenberg erautenberg approved these changes

@ImCoolNowRight ImCoolNowRight ImCoolNowRight approved these changes

@joshhowenstine joshhowenstine Awaiting requested review from joshhowenstine joshhowenstine is a code owner

@anthony9187 anthony9187 Awaiting requested review from anthony9187 anthony9187 is a code owner

@THoj13 THoj13 Awaiting requested review from THoj13

@arwehrman arwehrman Awaiting requested review from arwehrman

@jazzyw jazzyw Awaiting requested review from jazzyw

@soumyaloka soumyaloka Awaiting requested review from soumyaloka soumyaloka is a code owner

@slhay28 slhay28 Awaiting requested review from slhay28

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChrisArasin @svc-lightning-ui-components @ImCoolNowRight @erautenberg