fix(ControlRow): fix right controls to use lazyScrolling too #480
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erautenberg
requested review from
joshhowenstine,
anthony9187,
ImCoolNowRight,
THoj13,
arwehrman,
jazzyw,
soumyaloka and
slhay28
as code owners
ImCoolNowRight
approved these changes
Feb 29, 2024
joshhowenstine
approved these changes
Feb 29, 2024
ImCoolNowRight
force-pushed
the
fix/ControlRow
branch
from
7379263 to
4f0b495
Compare
|
Test Execution Failed. |
svc-lightning-ui-components
pushed a commit
that referenced
this pull request
Feb 29, 2024
# [@lightningjs/ui-components-v2.20.3](https://github.com/rdkcentral/Lightning-UI-Components/compare/@lightningjs/ui-components-v2.20.2...@lightningjs/ui-components-v2.20.3) (2024-02-29) ### Bug Fixes * **ControlRow:** fix right controls to use lazyScrolling too ([#480](#480)) ([9717848](9717848)) * **NavigationManager:** check an items render size before its set width or height for layout (important for Tiles using metadata underneath) ([#479](#479)) ([40d2e21](40d2e21)) * **NavigationManager:** fix render order and storybook glitches ([#468](#468)) ([a90457a](a90457a)) * **NavigationManager:** if an itemPosX or itemPosY are set, apply offset to scrolling ([#477](#477)) ([a02cf12](a02cf12)) * **TitleRow:** move title props to separate getter for easier extension of other components ([#478](#478)) ([ad34043](ad34043))
|
🎉 This PR is included in version @lightningjs/ui-components-v2.20.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The ControlRow currently has some odd scrolling behavior where we attempt to "alwaysScroll" on the right controls (like the left), but this creates some odd behaviors. It makes more sense to always lazyScroll on those pieces as well and only do the alwaysScroll for the leftmost controls. We can always tweak this further in the future (like if we want to "alwaysScroll" back from the right controls to the main content), but this makes it look less broken for the moment.
References
Testing
Confirm scrolling in the ControlRow stories look more intentional.
Automation
Checklist