[ONEM-26034] Use |innerText| for accessing dash.js subs content #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciej-kolanski-red
requested review from
lukasz-rutkowski-red and
pawel-bartkowiak-epam
HTML node property |textContent| returns text without any whitespaces. It leads to |DASH-FMP4-AVC1-AAC-TTML Subtitles| failures on dash.js, because the returned value is verified against expected text which inluced '\n' character. Usage of |innerText| property solves the above issue.
maciej-kolanski-red
force-pushed
the
ONEM-26034/2
branch
from
0b65c2d
to
dc10bdb
Compare
lukasz-rutkowski-red
approved these changes
Jul 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML node property |textContent| returns text without any whitespaces.
It leads to |DASH-FMP4-AVC1-AAC-TTML Subtitles| failures on dash.js,
because the returned value is verified against expected text which
inluced '\n' character.
Usage of |innerText| property solves the above issue.