[ONEM-25820] Major refactor #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change aims to simplify the codebase, especially in the area of tests declaration. Tests declaration has been moved into |suites.js|, where each test suite explicitly declares its own tests. There are still some helper functions for creation of multiple tests at once (makeMvtMediaTests), but I personally find it much more readable. Current approach also gives us much greater control when it comes tests selection and parametrization (e.g. now we can mark some tests unstable on a given test suite). In addition: - Declare name for each stream, so it can be accessed directly - Drop unnecessary attributes from stream mediaStreams.js - Greatly simplify profiles.js - Drop blocklist - now unstable tests are declared in suites.js - Rework codecSupportTests.js - Rework coverage.js - Extend readme
maciej-kolanski-red
requested review from
lukasz-rutkowski-red,
pawel-bartkowiak-epam and
piotr-marcinkowski-red
lukasz-rutkowski-red
force-pushed
the
refactor/3
branch
2 times, most recently
from
9c1e261
to
6b48ebc
Compare
lukasz-rutkowski-red
force-pushed
the
refactor/3
branch
from
6b48ebc
to
1f335f3
Compare
lukasz-rutkowski-red
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change aims to simplify the codebase, especially in the area of
tests declaration.
Tests declaration has been moved into |suites.js|, where each test suite
explicitly declares its own tests. There are still some helper functions
for creation of multiple tests at once (makeMvtMediaTests), but I
personally find it much more readable. Current approach also gives us
much greater control when it comes tests selection and parametrization
(e.g. now we can mark some tests unstable on a given test suite).
In addition: