Remove unnecessary clones (fixes #50) #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satlead
approved these changes
Nov 27, 2023
|
@adamdama & @satlead There is https://rust-lang.github.io/rust-clippy/master/#/redundant_clone but it will only catch redundant clones, not unnecessary. Meaning that if an object is cloned and dropped without any actions taking place it will be able to catch that. Unfortunately it looks like cloning an object counts as an action which is why the lint was not triggering. There doesn't look like there is a lint for cloning a whole data structure (i.e. HashMap) to only move out a value. Not sure if it is possible but might be something to bring up to the clippy team. |
satlead
added
the
needs-onboarding
Removes unnecessary clones by:
1) Removing the clone() call
2) Borrowing the value instead
3) Defering the clone() call on the item that needs to be cloned and
not the whole containing datastructure
StefanBossbaly
force-pushed
the
reduce-clone
branch
from
808b496 to
4087d0d
Compare
Nv-Delle1416
approved these changes
Jan 8, 2024
satlead
changed the title
satlead
added a commit
that referenced
this pull request
Jan 8, 2024
* Remove unnecessary clones
Removes unnecessary clones by:
1) Removing the clone() call
2) Borrowing the value instead
3) Defering the clone() call on the item that needs to be cloned and
not the whole containing datastructure
* Fixed lint and formatting issues
---------
Co-authored-by: Sathishkumar <satlead@gmail.com>
satlead
added a commit
that referenced
this pull request
Jan 8, 2024
* Remove unnecessary clones (fixes #50) (#326) * Remove unnecessary clones Removes unnecessary clones by: 1) Removing the clone() call 2) Borrowing the value instead 3) Defering the clone() call on the item that needs to be cloned and not the whole containing datastructure * Fixed lint and formatting issues --------- Co-authored-by: Sathishkumar <satlead@gmail.com> * Remove unnecessary clones (fixes #50) (#326) * Remove unnecessary clones Removes unnecessary clones by: 1) Removing the clone() call 2) Borrowing the value instead 3) Defering the clone() call on the item that needs to be cloned and not the whole containing datastructure * Fixed lint and formatting issues --------- Co-authored-by: Sathishkumar <satlead@gmail.com> --------- Co-authored-by: Stefan Bossbaly <Sbossb@gmail.com>
satlead
added a commit
that referenced
this pull request
Jan 12, 2024
* cherry-pick: Remove unnecessary clones (fixes #50) (#326) (#376) * Remove unnecessary clones (fixes #50) (#326) * Remove unnecessary clones Removes unnecessary clones by: 1) Removing the clone() call 2) Borrowing the value instead 3) Defering the clone() call on the item that needs to be cloned and not the whole containing datastructure * Fixed lint and formatting issues --------- Co-authored-by: Sathishkumar <satlead@gmail.com> * Remove unnecessary clones (fixes #50) (#326) * Remove unnecessary clones Removes unnecessary clones by: 1) Removing the clone() call 2) Borrowing the value instead 3) Defering the clone() call on the item that needs to be cloned and not the whole containing datastructure * Fixed lint and formatting issues --------- Co-authored-by: Sathishkumar <satlead@gmail.com> --------- Co-authored-by: Stefan Bossbaly <Sbossb@gmail.com> * fix: Context update (#379) * fix: Context Update not working for extensions * fix: for updating context token if available on boot --------- Co-authored-by: Stefan Bossbaly <Sbossb@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Removes unnecessary clones
Why
Clones increase memory usage and increase processing time.
How
Removes unnecessary clones by:
not the whole containing datastructure
Test
cargo test
Checklist