chore: enhance advertising.advertisingId API #331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maggie98choy
force-pushed
the
add-scope-param-for-advertising-advertisingId-API
branch
from
fb58369 to
df5b624
Compare
satlead
approved these changes
Nov 29, 2023
maggie98choy
force-pushed
the
add-scope-param-for-advertising-advertisingId-API
branch
from
df5b624 to
5d5e948
Compare
Swati-Chand
approved these changes
Dec 11, 2023
maggie98choy
deleted the
add-scope-param-for-advertising-advertisingId-API
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Enhance Advertising.advertisingId so that an optional scope can be passed from an app
Why
This changes is needed to meet implementation spec compliant
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist