Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Grant check fails to do case-insensitive comparison of privacy settings method #359

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

Vinodsathyaseelan
Copy link
Contributor

What

When the user grants policy has an entry for a privacy setting, the property (privacy method) will be checked to validate certain conditions.

To ensure backward compatibility of Firebolt API, the module part of the method needs to be compared in a case-insensitive manner. This was missing in the current implementation

Why

Why are these changes needed?

How

How do these changes achieve the goal?

Test

How has this been tested? How can a reviewer test it?

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@Vinodsathyaseelan Vinodsathyaseelan requested a review from a team December 14, 2023 16:15
@Vinodsathyaseelan Vinodsathyaseelan force-pushed the RPPL-1547 branch 2 times, most recently from 84c70b1 to 3626cd9 Compare December 15, 2023 01:22
@Vinodsathyaseelan Vinodsathyaseelan merged commit 4a341ab into main Dec 15, 2023
6 checks passed
@Vinodsathyaseelan Vinodsathyaseelan deleted the RPPL-1547 branch December 15, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants