fix: App ignore rules are causing all grant states to be true #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinodsathyaseelan
force-pushed
the
RPPL-1410
branch
from
3771220 to
0ca834f
Compare
Vinodsathyaseelan
changed the title
pahearn73
approved these changes
Dec 15, 2023
Swati-Chand
approved these changes
Jan 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
When a user places an AppId in the app_ignore_rules in manifest for *, it is setting all capabilities to granted and permitted
Expected : Giving * in app_ignore_rules should give the AppId full permissions for all available capabilities NOT grant all capabilities.
Why
There are separate exclusion list for app permissions and user grants. This is a bug where app ignore rules are bypassing user grants in addition to permission check.
How
Changes have been made to ensure that app ignore rules are applicable only for app permission check.
Test
How has this been tested? How can a reviewer test it?
Checklist