fix: Unsafe unwraps on session and message #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vinodsathyaseelan
approved these changes
Dec 15, 2023
B-Larsen
approved these changes
Dec 15, 2023
…fix-unsafe-unwraps
2 tasks
satlead
added a commit
that referenced
this pull request
Dec 19, 2023
* Fix auth (#327) * fix: Remove backup for Root token for device * fix: Cleanup feature flag for device tokens * fix: Fixed error message & code to: not supported & -50100 (#330) * fix: settings throwing custom error (#332) * Fix: Removed unsafe unwrap in account session (#346) * fix: Fixed some of the unsafe unwrap() associated with account session * feat: Handle undefined intents in LifecycleManagement.session (#344) * fix: Added sync_partner_exclusions API to fetch partner exclusion data on (#342) * Fix session id metrics is empty (#350) * fix: session_id in metrics payload is empty * fix: update code to assign metrics_state.device_session_id using platform_state.device_session_id * fix: Add Missing partner id in context (#356) * fix: Grant check fails to do case-insensitive comparison of privacy settings method (#361) * fix: Unsafe unwraps on session and message (#362) --------- Co-authored-by: Brindha Senthil <brindasen22@gmail.com> Co-authored-by: Vinod Sathyaseelan <Vinod_sathyaseelan@comcast.com> Co-authored-by: Maggie Choy <maggie98choy@yahoo.com>
satlead
added a commit
that referenced
this pull request
Jan 3, 2024
* Fix auth (#327) * fix: Remove backup for Root token for device * fix: Cleanup feature flag for device tokens * fix: Fixed error message & code to: not supported & -50100 (#330) * fix: settings throwing custom error (#332) * Fix: Removed unsafe unwrap in account session (#346) * fix: Fixed some of the unsafe unwrap() associated with account session * feat: Handle undefined intents in LifecycleManagement.session (#344) * fix: Added sync_partner_exclusions API to fetch partner exclusion data on (#342) * Fix session id metrics is empty (#350) * fix: session_id in metrics payload is empty * fix: update code to assign metrics_state.device_session_id using platform_state.device_session_id * fix: Add Missing partner id in context (#356) * fix: Grant check fails to do case-insensitive comparison of privacy settings method (#361) * fix: Unsafe unwraps on session and message (#362) * fix: Session with grant resolution (#368) * fix: Session with grant resolution * fix: For settings propagation * chore: Bump 1.0.1 (#371) --------- Co-authored-by: Brindha Senthil <brindasen22@gmail.com> Co-authored-by: Vinod Sathyaseelan <Vinod_sathyaseelan@comcast.com> Co-authored-by: Maggie Choy <maggie98choy@yahoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
What does this PR add or remove?
Why
Why are these changes needed?
How
How do these changes achieve the goal?
Test
How has this been tested? How can a reviewer test it?
Checklist