Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: making account_link_processor pass through #363

Merged
merged 6 commits into from
Jan 30, 2024

Conversation

Karthick-Somasundaresan
Copy link
Contributor

@Karthick-Somasundaresan Karthick-Somasundaresan commented Dec 15, 2023

What

We are removing the need for determining the ProgressUnit and making account_link_processor a mere pass-through

Why

The distributor can decide on business logic to determine the unit type

How

It will pass the exact value that the application has shared to the distributor without inserting any business logic

Test

By manual testing

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@Karthick-Somasundaresan Karthick-Somasundaresan requested a review from a team January 9, 2024 05:05
Copy link

github-actions bot commented Jan 30, 2024

Code Coverage

Package Line Rate Health
core.sdk.src.framework 68%
core.main.src.firebolt.handlers 1%
core.sdk.src.api.manifest 31%
core.tdk.src 100%
core.main.src.state 21%
device.thunder_ripple_sdk.src 14%
core.launcher.src 1%
core.main.src.bootstrap.extn 0%
core.sdk.src.api.distributor 0%
core.sdk.src.api.gateway 26%
core.main.src.service 27%
core.sdk.src.utils 48%
core.tdk.src.utils 79%
device.thunder.src.bootstrap 0%
device.thunder_ripple_sdk.src.bootstrap 0%
device.thunder_ripple_sdk.src.events 4%
core.sdk.src.api.firebolt 25%
device.thunder_ripple_sdk.src.processors.events 0%
core.sdk.src.extn.ffi 22%
core.main.src.processor 0%
core.main.src.service.extn 27%
core.main.src.firebolt 1%
device.thunder_ripple_sdk.src.processors 4%
device.thunder_ripple_sdk.src.client 15%
core.main.src.utils 13%
core.launcher.src.manager 7%
core.main.src.state.cap 43%
core.main.src.processor.storage 0%
core.main.src.service.apps 23%
core.sdk.src 100%
core.sdk.src.api 3%
core.sdk.src.extn 37%
core.tdk.src.gateway 100%
distributor.general.src 2%
device.thunder.src 2%
core.sdk.src.extn.client 10%
core.main.src 6%
core.main.src.bootstrap.manifest 0%
core.sdk.src.api.device 41%
core.main.src.bootstrap 0%
Summary 13% (3522 / 26657)

Minimum allowed line rate is 10%

Current coverage:13% exceeds coverage threshold. Coverage threshold will be updated automatically to reflect to the latest coverage when this pr is merged to main branch.

@Karthick-Somasundaresan Karthick-Somasundaresan merged commit a477061 into main Jan 30, 2024
8 checks passed
@Karthick-Somasundaresan Karthick-Somasundaresan deleted the account_link_progress branch January 30, 2024 15:57
@satlead satlead added this to the ripple-1.2.0 milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants