Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Changes for Rule engine and better run script #580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

satlead
Copy link
Collaborator

@satlead satlead commented Jul 26, 2024

What

Adds support for reusing run script to run Ripple pointing to a device
Upgrades Rules engine to be case insensitive

Why

For better developer experience and configuration

How

Making the key and check case insensitive, and upgrading the scripts and configuration for Device Host.

Test

Ripple run script is updated to use the DEVICE_HOST variable instead of Thunder Host.
Ripple developers can use any case for the method field.

Checklist

  • I have self-reviewed this PR
  • I have added tests that prove the feature works or the fix is effective

@CLAassistant
Copy link

CLAassistant commented Jul 26, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

Code Coverage

Package Line Rate Health
core.sdk.src.api.observability 68%
core.sdk.src.api.firebolt 78%
core.tdk.src.utils 0%
core.main.src.broker 35%
device.thunder.src.bootstrap 0%
core.launcher.src 0%
core.main.src.firebolt.handlers 8%
core.main.src.service.extn 40%
core.sdk.src.extn 83%
core.main.src.service.apps 47%
core.main.src.bootstrap 0%
core.sdk.src.api.manifest 91%
core.main.src.processor 0%
core.sdk.src.api.distributor 84%
core.sdk.src.framework 75%
device.thunder_ripple_sdk.src.client 74%
core.main.src.state 26%
device.thunder_ripple_sdk.src.processors.events 0%
openrpc_validator.src 90%
core.sdk.src.api.gateway 87%
core.sdk.src.api 78%
core.sdk.src.api.device 77%
core.main.src.utils 29%
core.launcher.src.manager 7%
core.sdk.src.extn.ffi 80%
device.mock_device.src 52%
device.thunder_ripple_sdk.src.bootstrap 0%
core.main.src 0%
core.main.src.service 31%
device.thunder.src 0%
core.main.src.state.cap 44%
core.main.src.bootstrap.extn 0%
core.tdk.src.gateway 100%
device.thunder_ripple_sdk.src.processors 10%
device.thunder_ripple_sdk.src 15%
distributor.general.src 2%
core.sdk.src.extn.client 91%
core.main.src.broker.thunder 54%
core.main.src.processor.storage 0%
device.thunder_ripple_sdk.src.events 4%
core.main.src.firebolt 4%
core.sdk.src.utils 53%
core.main.src.bootstrap.manifest 0%
Summary 43% (17639 / 40593)

Minimum allowed line rate is 41%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants