sat change to get value from intent #235
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -434,10 +426,16 @@ export default class App extends Base { | |||
| } | |||
|
|
|||
| // Set the pubSub URL if present | |||
| console.log('2507 test log - query params', query.params); | |||
There was a problem hiding this comment.
Please remove all the debug logs before merging.
There was a problem hiding this comment.
yes, will be removed once we test on sky/foxtel
kevinshahfws
approved these changes
Oct 29, 2024
kschrief
requested changes
Oct 29, 2024
| if (query.params.pubSubUrl) { | ||
| process.env.PUB_SUB_URL = query.params.pubSubUrl; | ||
| console.log('2507 test log - query params pubsuburl', process.env.PUB_SUB_URL); |
There was a problem hiding this comment.
Debug logs can be removed.
| // Set the pubSub token if present | ||
| if (query.params.pubSubToken) { | ||
| process.env.PUB_SUB_TOKEN = query.params.pubSubToken; | ||
| console.log('2507 test log - query params pubsubtoken', process.env.PUB_SUB_TOKEN); |
There was a problem hiding this comment.
Debug logs can be removed.
| console.log('2507 test log - query params pubsuburl', process.env.PUB_SUB_URL); | ||
| } | ||
| // Set the pubSub token if present | ||
| if (query.params.pubSubToken) { |
There was a problem hiding this comment.
We should add an entry to search for this in the URL as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enter a detailed description of the PR here, including the nature and purpose of the changes.
JIRA Ticket
Include a link to the JIRA Ticket linked to this PR.
Issue-0000
Additional Info (Test steps / Steps to reproduce etc.)
Details on how to test the feature