Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firecert 2186 #118

Merged
merged 6 commits into from
Jun 28, 2024
Merged

Firecert 2186 #118

merged 6 commits into from
Jun 28, 2024

Conversation

anjalimukundan
Copy link
Contributor

No description provided.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/plugins/testDataProcessor.js
  68:33  error  Replace `·:·validationObjects` with `:·validationObjects,`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  331:18  error  Replace `"Response·from·configModule·for·customValidation·>>>·")` with `'Response·from·configModule·for·customValidation·>>>·');`                                                                                                                                                                                                                                                 prettier/prettier
  332:11  error  Insert `;`                                                                                                                                                                                                                                                                                                                                                                        prettier/prettier
  334:16  error  Replace `false,·`Expected·validationObject·to·be·of·"custom"·type.·Current·value·:·${Cypress.env(CONSTANTS.COMBINEVALIDATIONOBJECTSJSON)[validationObject].data[0].type}`` with `⏎··········false,⏎··········`Expected·validationObject·to·be·of·"custom"·type.·Current·value·:·${Cypress.env(CONSTANTS.COMBINEVALIDATIONOBJECTSJSON)[validationObject].data[0].type}`⏎········`  prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@anjalimukundan anjalimukundan changed the base branch from main to dev June 20, 2024 11:50
jbigel
jbigel previously approved these changes Jun 24, 2024
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/constants/constants.js
  67:22  error  Insert `⏎···`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@Abhishk123 Abhishk123 merged commit 6153708 into dev Jun 28, 2024
5 checks passed
@Abhishk123 Abhishk123 deleted the FIRECERT-2186 branch June 28, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants