Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRECERT-2169: [FCS] Implement Setter/Getter validation Glue Code #119

Merged
merged 10 commits into from
Jun 28, 2024

Conversation

Abhishk123
Copy link
Contributor

No description provided.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  807:62  error  Replace `?·getEnvVariable('runtime')[input]` with `⏎··········?·getEnvVariable('runtime')[input]⏎·········`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  394:1   error  Delete `⏎`                                                                                                                                                                                                                                  prettier/prettier
  395:1   error  Expected space or tab after '//' in comment                                                                                                                                                                                                 spaced-comment
  453:13  error  'contentObject' is never reassigned. Use 'const' instead                                                                                                                                                                                    prefer-const
  479:36  error  Replace `method,·errorExpected,·CONSTANTS.METHOD,·context,·appId,·param).then(` with `⏎··············method,⏎··············errorExpected,⏎··············CONSTANTS.METHOD,⏎··············context,⏎··············appId,⏎··············param`  prettier/prettier
  480:13  error  Replace `··` with `).then(`                                                                                                                                                                                                                 prettier/prettier
  481:1   error  Delete `··`                                                                                                                                                                                                                                 prettier/prettier
  482:1   error  Replace `··············}⏎············` with `············}`                                                                                                                                                                                 prettier/prettier
  493:27  error  'validationPath' is never reassigned. Use 'const' instead                                                                                                                                                                                   prefer-const
  597:3   error  Insert `⏎`                                                                                                                                                                                                                                  prettier/prettier

✖ 10 problems (10 errors, 0 warnings)
  10 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  807:62  error  Replace `?·getEnvVariable('runtime')[input]` with `⏎··········?·getEnvVariable('runtime')[input]⏎·········`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  394:1   error  Delete `⏎`                                                 prettier/prettier
  395:1   error  Expected space or tab after '//' in comment                spaced-comment
  452:13  error  'contentObject' is never reassigned. Use 'const' instead   prefer-const
  473:19  error  'errorObject' is never reassigned. Use 'const' instead     prefer-const
  500:27  error  'validationPath' is never reassigned. Use 'const' instead  prefer-const
  604:3   error  Insert `⏎`                                                 prettier/prettier

✖ 7 problems (7 errors, 0 warnings)
  7 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@rdkcmf-jenkins
Copy link

Coverity detected 1 issue; a quality concern.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  842:62  error  Replace `?·getEnvVariable('runtime')[input]` with `⏎··········?·getEnvVariable('runtime')[input]⏎·········`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  394:1   error  Delete `⏎`                                                 prettier/prettier
  395:1   error  Expected space or tab after '//' in comment                spaced-comment
  452:13  error  'contentObject' is never reassigned. Use 'const' instead   prefer-const
  473:19  error  'errorObject' is never reassigned. Use 'const' instead     prefer-const
  500:27  error  'validationPath' is never reassigned. Use 'const' instead  prefer-const
  604:3   error  Insert `⏎`                                                 prettier/prettier

✖ 7 problems (7 errors, 0 warnings)
  7 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/plugins/testDataProcessor.js
   71:57  error  Insert `,`                                                  prettier/prettier
  114:7   error  'errorSchemaJson' is never reassigned. Use 'const' instead  prefer-const
  135:35  error  'validationObject.type' is assigned to itself               no-self-assign
  145:2   error  Delete `⏎`                                                  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  842:62  error  Replace `?·getEnvVariable('runtime')[input]` with `⏎··········?·getEnvVariable('runtime')[input]⏎·········`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  394:1   error  Delete `⏎`                                                 prettier/prettier
  395:1   error  Expected space or tab after '//' in comment                spaced-comment
  454:13  error  'contentObject' is never reassigned. Use 'const' instead   prefer-const
  498:27  error  'validationPath' is never reassigned. Use 'const' instead  prefer-const
  602:3   error  Insert `⏎`                                                 prettier/prettier

✖ 10 problems (10 errors, 0 warnings)
  9 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  452:13  error  'contentObject' is never reassigned. Use 'const' instead   prefer-const
  497:27  error  'validationPath' is never reassigned. Use 'const' instead  prefer-const

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/validations.js
  458:9  error  'contentObject' is constant  no-const-assign

✖ 1 problem (1 error, 0 warnings)

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

neeradanelxsi
neeradanelxsi previously approved these changes Jun 25, 2024
jbigel
jbigel previously approved these changes Jun 26, 2024
neeradanelxsi
neeradanelxsi previously approved these changes Jun 26, 2024
@Abhishk123 Abhishk123 dismissed stale reviews from neeradanelxsi and jbigel via 504a352 June 28, 2024 10:02
@Abhishk123 Abhishk123 merged commit 2380e9d into dev Jun 28, 2024
5 checks passed
@Abhishk123 Abhishk123 deleted the FIRECERT-2169 branch June 28, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants