Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIRECERT-1529: [FCS] Add ability to subscribe to multiple appId's in App calls, App registers, validation glue #120

Merged
merged 6 commits into from
Jun 28, 2024

Conversation

Eswar2103
Copy link
Contributor

No description provided.

@Eswar2103 Eswar2103 changed the base branch from main to dev June 21, 2024 13:38
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  646:29  error  Replace `·?·UTILS.getEnvVariable(CONSTANTS.THIRD_PARTY_APP_ID)` with `⏎······?·UTILS.getEnvVariable(CONSTANTS.THIRD_PARTY_APP_ID)⏎·····`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  637:39  error  Insert `·`                                                                                                                                                                                                                                                                                        prettier/prettier
  647:12  error  Replace `.info(`Unable·to·find·the·${envAppIdKey}·value·in·the·env,·please·add·the·value·in·config·module/constants/config.json`)` with `⏎······.info(⏎········`Unable·to·find·the·${envAppIdKey}·value·in·the·env,·please·add·the·value·in·config·module/constants/config.json`⏎······)⏎······`  prettier/prettier
  648:1   error  Insert `··`                                                                                                                                                                                                                                                                                       prettier/prettier
  649:1   error  Insert `··`                                                                                                                                                                                                                                                                                       prettier/prettier

✖ 5 problems (5 errors, 0 warnings)
  5 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

neeradanelxsi
neeradanelxsi previously approved these changes Jun 24, 2024
jbigel
jbigel previously approved these changes Jun 24, 2024
@Eswar2103 Eswar2103 dismissed stale reviews from neeradanelxsi and jbigel via 4db448d June 25, 2024 13:34
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  655:12  error  Replace `⏎······.info(⏎········eval(CONSTANTS.SECONDARY_APPID_MISSING_ERROR)⏎······)⏎······` with `.info(eval(CONSTANTS.SECONDARY_APPID_MISSING_ERROR))`  prettier/prettier
  660:1   error  Delete `··`                                                                                                                                               prettier/prettier
  661:1   error  Delete `··`                                                                                                                                               prettier/prettier

✖ 3 problems (3 errors, 0 warnings)
  3 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@Abhishk123 Abhishk123 merged commit 6c17eb0 into dev Jun 28, 2024
5 checks passed
@Abhishk123 Abhishk123 deleted the FIRECERT-1529 branch June 28, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants