Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FCS] Setter/Getter Code Refactoring #147

Merged
merged 19 commits into from
Jul 23, 2024
Merged

[FCS] Setter/Getter Code Refactoring #147

merged 19 commits into from
Jul 23, 2024

Conversation

Abhishk123
Copy link
Contributor

No description provided.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  838:1   error  Delete `⏎`                                               prettier/prettier
  982:11  error  'errorContent' is never reassigned. Use 'const' instead  prefer-const

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/fireboltCalls.js
  618:43  error  Replace `'Platform',·additionalParams,·CONSTANTS.TASK.REGISTEREVENT` with `⏎··············'Platform',⏎··············additionalParams,⏎··············CONSTANTS.TASK.REGISTEREVENT⏎············`  prettier/prettier

✖ 3 problems (3 errors, 0 warnings)
  3 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  838:1   error  Delete `⏎`                                               prettier/prettier
  982:11  error  'errorContent' is never reassigned. Use 'const' instead  prefer-const

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  838:1   error  Delete `⏎`                                               prettier/prettier
  982:11  error  'errorContent' is never reassigned. Use 'const' instead  prefer-const

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  838:1   error  Delete `⏎`                                               prettier/prettier
  982:11  error  'errorContent' is never reassigned. Use 'const' instead  prefer-const

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/getterSetterCalls.js
  519:9  error  Delete `·`  prettier/prettier

✖ 3 problems (3 errors, 0 warnings)
  3 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  838:1   error  Delete `⏎`                                               prettier/prettier
  983:11  error  'errorContent' is never reassigned. Use 'const' instead  prefer-const

✖ 2 problems (2 errors, 0 warnings)
  2 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@Abhishk123 Abhishk123 changed the title FIRECERT-2196: [FCS] Setter/Getter Code Refactoring [FCS] Setter/Getter Code Refactoring Jul 11, 2024
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  1002:11  error  'errorContent' is never reassigned. Use 'const' instead  prefer-const

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  1002:11  error  'errorContent' is never reassigned. Use 'const' instead  prefer-const

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/getterSetterCalls.js
   71:34  error  Insert `;`  prettier/prettier
  126:46  error  Insert `;`  prettier/prettier

✖ 3 problems (3 errors, 0 warnings)
  3 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  1002:27  error  Insert `⏎·······`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

jbigel
jbigel previously approved these changes Jul 15, 2024
Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/step_definitions/fireboltCalls.js
  118:1  error  Delete `·⏎`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting or unit tests detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  848:56  error  Insert `;`  prettier/prettier
  874:57  error  Delete `·`  prettier/prettier

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-support/src/utils.js
  888:1  error  Delete `⏎`  prettier/prettier
  897:1  error  Delete `·`  prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

@Abhishk123 Abhishk123 merged commit 6e5f32f into dev Jul 23, 2024
5 checks passed
@Abhishk123 Abhishk123 deleted the FIRECERT-2196 branch July 23, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants