feat: Start/stop performance metrics collection for each test case without glue code #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue with linting detected. For more information on our linting policies, please see our Linting-Guide. |
jbigel
reviewed
Oct 30, 2024
| */ | ||
| Cypress.Commands.add('initiatePerformanceMetrics', () => { | ||
| // Retrieve the scenario name from the env. | ||
| const scenarioName = Cypress.env(CONSTANTS.SCENARIO_NAME); |
There was a problem hiding this comment.
It seems like we only need the scenarioName when we enter the if condition on line 1564. Do we need it to be defined outside of that block?
There was a problem hiding this comment.
defined scenarioName inside if block.
| */ | ||
| Cypress.Commands.add('performanceValidation', (object) => { | ||
| // Check if performance metrics are enabled | ||
| if (UTILS.getEnvVariable('performanceMetrics')) { |
There was a problem hiding this comment.
Here: https://github.com/rdkcentral/firebolt-certification-suite/pull/236/files#diff-a0c4b6497a6be8ded74b56b3268804337f0607a41306ae7c236b91b7a7fab118R1564 - use a constant for performance metrics, can we not use the same here?
There was a problem hiding this comment.
changed to constant
neeradanelxsi
approved these changes
Nov 3, 2024
jbigel
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.