-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Deep link implementation #268
base: dev
Are you sure you want to change the base?
Conversation
Issue with linting detected.
For more information on our linting policies, please see our Linting-Guide. |
Issue with linting detected.
For more information on our linting policies, please see our Linting-Guide. |
Issue with linting detected.
For more information on our linting policies, please see our Linting-Guide. |
Issue with linting detected.
For more information on our linting policies, please see our Linting-Guide. |
Issue with linting detected.
For more information on our linting policies, please see our Linting-Guide. |
Issue with linting detected.
For more information on our linting policies, please see our Linting-Guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good for the most part outside of the one change for resolveAtRuntime
. For the documentation I'm wondering if we need more details on what intent is and how to use it as well as app data.
// If the input contains '->', Consdering it as an object path and extracting the value from the object | ||
if (pattern.includes('->')) { | ||
return extractValueFromObjectPath(pattern); | ||
} else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here I think instead of an 'else' we can just check if there is a functionName and it should handle the case I mentioned in the call this morning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed the comment
First we are going to fetch the value from the object then calling function to change the case
e63e612
No description provided.