Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Deep link implementation #268

Open
wants to merge 28 commits into
base: dev
Choose a base branch
from
Open

Conversation

Abhishk123
Copy link
Contributor

No description provided.

Copy link

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  941:9  error  Insert `·`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  918:9  error  'data' is never reassigned. Use 'const' instead  prefer-const

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

github-actions bot commented Dec 6, 2024

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  917:75  error  Insert `,`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

github-actions bot commented Dec 9, 2024

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  917:75  error  Insert `,`  prettier/prettier

✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  1689:50  error  Insert `;`  prettier/prettier
  1692:72  error  Insert `;`  prettier/prettier
  1731:9   error  Insert `;`  prettier/prettier
  1732:24  error  Insert `;`  prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link

Issue with linting detected.
Linting failed with the following errors:

yarn run v1.22.22
$ eslint .

/home/runner/work/firebolt-certification-suite/firebolt-certification-suite/cypress/support/cypress-commands/commands.js
  1689:50  error  Insert `;`  prettier/prettier
  1692:72  error  Insert `;`  prettier/prettier
  1731:9   error  Insert `;`  prettier/prettier
  1732:24  error  Insert `;`  prettier/prettier

✖ 4 problems (4 errors, 0 warnings)
  4 errors and 0 warnings potentially fixable with the `--fix` option.

info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

For more information on our linting policies, please see our Linting-Guide.

Copy link
Contributor

@jbigel jbigel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good for the most part outside of the one change for resolveAtRuntime. For the documentation I'm wondering if we need more details on what intent is and how to use it as well as app data.

// If the input contains '->', Consdering it as an object path and extracting the value from the object
if (pattern.includes('->')) {
return extractValueFromObjectPath(pattern);
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here I think instead of an 'else' we can just check if there is a functionName and it should handle the case I mentioned in the call this morning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed the comment
First we are going to fetch the value from the object then calling function to change the case

neeradanelxsi
neeradanelxsi previously approved these changes Dec 13, 2024
jbigel
jbigel previously approved these changes Dec 13, 2024
@Abhishk123 Abhishk123 dismissed stale reviews from jbigel and neeradanelxsi via e63e612 December 16, 2024 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants